amichaeltm / BDSup2SubPlusPlus

Port of the original BDSup2Sub to C++ and Qt.
Apache License 2.0
30 stars 6 forks source link

Fix bad XML/PNG output from multiple ODS sup. #2

Closed amichaeltm closed 6 years ago

amichaeltm commented 6 years ago

This sup file can cause the program to export a bad XML/PNG stream.

From r0lz bug report:

BDSup2Sub++ doesn't show any warning and is supposed to handle correctly the multiple ODS. However, when it exports that stream to XML/PNG, it creates a bad stream. For example, subtitle 2 is exported as two PNGs. The second PNG is fully transparent and therefore useless. Subtitle 3 is exported as two identical PNGs. Furthermore, each time a single subtitle is exported as several PNGs, the entries for that PNGs are wrong in the XML. The bad entries can be null coordinates: or they can reference PNG files that have not been created. The resulting XML/PNG cannot be loaded correctly in any version of BDSup2Sub.

False_positives_of_multiple_ODS.zip

amichaeltm commented 6 years ago

Fixed with latest commits.