global offsets > 0 in IDX lead to wrong image size

amichaeltm / BDSup2SubPlusPlus

Port of the original BDSup2Sub to C++ and Qt.

Apache License 2.0

30 stars 6 forks source link

global offsets > 0 in IDX lead to wrong image size #22

Closed pprkut closed 2 years ago

pprkut commented 3 years ago

I'm trying to load vobsub subtitles into BDSup2Sub++, but I'm running into an issue where the image size is calculated wrongly for all subtitles except the first one. See screenshot for example:

screenshot

I found a changelog entry in BDSup2Sub (3.7.1 -> 3.8.0) that looks exactly like the issue I'm having:

Fixed: VobSub: global offsets > 0 in IDX led to wrong image size (and wrong RLE decoding in some cases).

captainayy commented 2 years ago

It was not related to that. I have a fix for this issue that I'll send a pull request for.

captainayy commented 2 years ago

This is now fixed with the pull request.