amichaeltm / BDSup2SubPlusPlus

Port of the original BDSup2Sub to C++ and Qt.
Apache License 2.0
30 stars 6 forks source link

Save new forced captions directly #7

Closed hubblec4 closed 6 years ago

hubblec4 commented 6 years ago

For now you have to set the new forced sups, then save the entire sup with the new forced sups. Then load the new sup file and then save forced sups.

It would be great to save the new forced sups directly.

amichaeltm commented 6 years ago

Can you explain this more? I'm not understanding what you are saying. What do you mean by "save the new forced sups directly"?

hubblec4 commented 6 years ago

Sometimes is on Blu-ray a sup stream without forced captions(but some captions should be) and no extra forced sup file. I load this sup file and set some captions as forced. Now I click on save, the save dialog opens but the checkbox "Export only forced" is disabled(gray). I must save the entire new sup with forced captions, then I have to load the new sup file and can save the "only forced" captions to new forced_only_sup file.

What I want is that I can save the forced captions to a new forced_only_sup file directly after I set the new forced captions.

amichaeltm commented 6 years ago

Ok. Thanks. That helps.

amichaeltm commented 6 years ago

Yeah, this seems trickier than I expected. This seems to be inherited from the Java program's design where that option seems to only be enabled if the input SUP had subtitles marked as forced as the Java version has the same behavior. Won't be impossible to fix but will require some tweaking of how it determines whether there are forced subtitles when exporting.

hubblec4 commented 6 years ago

OK, I understand and hope you can change this behavior.

amichaeltm commented 6 years ago

I will definitely change it. Just requires a bit of refactoring work.

hubblec4 commented 6 years ago

Splendid, and many thanks.

amichaeltm commented 6 years ago

Fixed with 0b243caccdcab1fc68b29b4b45b6b29ff2ef1b65

hubblec4 commented 6 years ago

Many Thanks.