amici-ursi / ImagesOfNetwork

Tools for managing the ImagesOfNetwork on reddit
MIT License
7 stars 9 forks source link

Investigate praw 4.0 #87

Closed scowcron closed 8 years ago

scowcron commented 8 years ago

Preliminary investigation needed. It's still in beta right now, but it might benefit both us and the praw maintainers if we pick it up. amici thinks that logging might becoming (OH YEAH!). also, it'll break everything we have. See just how much work it will take.

13steinj commented 8 years ago

Emailing from mobile here:

Praw 4 for the most part is the same as praw3 it seems except for the naming scheme-- the get_ prefix is removed from methods. Rate limiting is improved as dynamic via the response headers rather than praw blocking the thread with a time.sleep timeout. The authentication model and workflow has changed, mostly for the better.

However beta is a bit of an understatement-- it shouldn't be used until at least an actual release, many features that exist in praw3 aren't in praw4 as of yet due to the full rewrite. Don't particularly know how many would or would not be needed. On Jun 9, 2016 2:21 AM, "Nathan Scowcroft" notifications@github.com wrote:

Preliminary investigation needed. It's still in beta right now, but it might benefit both us and the praw maintainers if we pick it up. amici thinks that logging might becoming (OH YEAH!). also, it'll break everything we have. See just how much work it will take.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/amici-ursi/ImagesOfNetwork/issues/87, or mute the thread https://github.com/notifications/unsubscribe/AKCaLnqGZXSyLNw_i7yP9KGuuytex7Eeks5qJ7DhgaJpZM4Ixqet .

scowcron commented 8 years ago

Also no use logging. Between these things, i'm going to go with no, at least for now.