feature/devops-310-update - Githubissues

amida-tech / api-boilerplate

Node ES6 Express REST API boilerplate with Postgres Sequelize and Gulp

Apache License 2.0

153 stars 57 forks source link

feature/devops-310-update #4

Closed unprofessional closed 6 years ago

unprofessional commented 6 years ago

What's this PR do?

updates packages that had security vulnerabilities
updates the Dockerfile
replaces mocha/chai with Jest
adds a test database environment variable dependent on NODE_ENV=test because I didn't feel comfortable running tests on the "production" database

Related JIRA tickets:

https://jira.amida-tech.com/browse/DEVOPS-310

How should this be manually tested?

create production database
run the app and POST to /users to create
create a test database
run yarn test
test the Dockerfile via:
- docker build -t test-api-boilerplate . to build
- docker run --rm -e JWT_SECRET="safsdfds" -e SUBSCRIPTION_SERVICE_URL="http://localhost:4040" -e KAFKA_SERVER_HOST=localhost test-api-boilerplate to run.

Any background context you want to provide?

BACKGROUND -- this was generally outdated, but we've been building many microservices on top of this codebase and introduced those outdated issues into our newer projects, so this needed to be updated accordingly

Screenshots (if appropriate):

unprofessional commented 6 years ago

I didn't like having to mutate a const (for the encryption config stuff), so I implemented a spread-operator refactor instead (which could come in handy as ES6 becomes more prevalent).

I think this is good for another pass.