search

amidaware / community-scripts

A curated list of powershell, python, and batch scripts for use in TacticalRMM or anywhere!
MIT License
119 stars 82 forks source link

Delete scripts/Win_RustDesk_GetID.ps1 #179

Closed dinger1986 closed 1 year ago

dinger1986 commented 1 year ago

script doesnt work, best to work from docs and keep everything out of scripts for RustDesk

silversword411 commented 1 year ago

I've been debating how to handle the existing rustdesk stuff.

Rustdesk definitely in flux atm. Probably best to pull, if there are installs in the field this is going to mess with status.

We still have the outstanding bug about deleting community scripts causing problems in the field. Need to refresh memory and check before accepting this.

dinger1986 commented 1 year ago

I think its best to keep it in the docs, one place to update, its reliant on users having a custom field setup as well.

The script doesnt work with 1.2.2 so pointless having it

NiceGuyIT commented 1 year ago

We still have the outstanding big about deleting community scripts causing problems in the field. Need to refresh memory and check before accepting this.

The issue is if a community script is deleted, the corresponding check (and task?) will be silently deleted when people update. It's better to update the script with a message and exit with an error. That will signal to the observant user that the script is no longer working. If people don't monitor for errors from scripts, that's on them.

dinger1986 commented 1 year ago

ok yes that makes sense, its just to try and not have to maintain scripts in 2 places and then rustdesk update something and people say well trmm isnt up to date

silversword411 commented 1 year ago

This was the one: https://github.com/amidaware/tacticalrmm/issues/1486

Should probably have some kind of obvious naming convention and keyword(s).

dinger1986 commented 1 year ago

So we should rename the script to !!!Broken - Read Docs or something similar?

dinger1986 commented 1 year ago

So we should rename the script to !!!Broken - Read Docs or something similar?