amidaware / community-scripts

A curated list of powershell, python, and batch scripts for use in TacticalRMM or anywhere!
MIT License
121 stars 82 forks source link

Add RunAsUser and env vars to Community scripts .json for prefilled default deployment #245

Open silversword411 opened 2 months ago

cdp1337 commented 2 months ago

Issue:

When creating a custom script meant for deployment, it is possible to assign default execution parameters to the scripts as per https://github.com/amidaware/community-scripts/blob/main/community_scripts.schema.json (refer to the following directive:

"args": {
        "description": "The script arguments listed as an array.",
        "type": "array",
        "items": {
          "type": "string"
        }
      },

However, at the moment it is not possible to define defaults for environmental variables and the Windows-only option of "Run As User".

For the environmental variables option, it makes sense to stick with the same format as args as they share similar functionality, (just different implementations).

Proposal:

"env": {
        "description": "The environmental variables when running the script listed as an array.",
        "type": "array",
        "items": {
          "type": "string"
        }
      },
"run_as_user": {
        "description": "Run this script as the active user as opposed to System (Windows only)",
        "type": "boolean"
      },

Be added to the schema and modification of the underlying script importer (if necessary), to support these new defaults.

(Example proposal, obviously feel free to implement how you see fit)