amidaware / rmmagent

Tactical RMM Agent

https://github.com/amidaware/tacticalrmm

Other

129 stars 75 forks source link

[Feature] Add cross site scripting #38

Closed NiceGuyIT closed 7 months ago

NiceGuyIT commented 10 months ago

This PR adds support for Nushell and Deno to provide a cross platform scripting environments.

Associated PRs

rmmagent: amidaware/rmmagent#38
tacticalrmm: amidaware/tacticalrmm#1676
tacticalrmm-web: amidaware/tacticalrmm-web#14
trmm-docs: amidaware/trmm-docs#217
community-scripts: TBD

Questions

macOS uses /opt/tacticalagent but Linux does not. Should this be created to hold the nu and deno binaries?
- Added /opt/tacticalagent to the Linux agent and uninstall script.
Should the *nix binaries reside in /opt/tacticalagent/bin/? I noticed the Mac agent is in /opt/tacticalagent/tacticalagent and stores old versions as *-v1.2.3.
- Yes.

Out of scope.

macOS: /opt/tacticalagent permissions (o-rwx, 0x750) do not permit reading by the user. When Run As User is implemented for Mac/Linux, this will need to be changed.
- A fresh install has the correct permissions. This should not be an issue.

TODO

These items are done.

[x] Download and uncompress the files from GitHub
[x] Save them in Tactical's "bin" directory (platform dependent).

wh1te909 commented 10 months ago

thank you, hoping to get some time soon to test this out

NiceGuyIT commented 10 months ago

The following changes were made. I hope to test this more thoroughly later this week.

Added settings to control Nushell and Deno. The default is opt-out.
Use the Nushell and Deno versions stored on the TRMM server.
Support downloading Nushell and Deno from a url (not GitHUb). Authentication is not supported.
Add support for nu config.nu and env.nu files. Empty files are created.
Add support for default Deno permissions. Using DENO_PERMISSIONS environmental variable overrides this.

The NUSHELL_ENABLE_CONFIG and DENO_DEFAULT_PERMISSIONS variables are stored in the settings and sent to the agents when scripts are run. This is not meant to be editable per script. This may change in the future.

Design question

Currently the bin and etc directories are stored in C:\Program Files\TacticalRMM\bin and ...\etc following the Python lead. Should these be stored in C:\ProgramData\TacticalRMM\bin and ...\etc following Chocolatey's lead?

NiceGuyIT commented 10 months ago

Hey @wh1te909, I merged the latest (after the last release) and fixed a formatting error in tacticalrmm. Everything is ready to go. Let me know if there's anything I can do to help the testing.

NiceGuyIT commented 9 months ago

Is there an update on this?

If the PR is not going to be accepted, please close so I can make other arrangements.

wh1te909 commented 8 months ago

sorry for the delay, yes plan to accept will try to test after next release