initial SysTray PR - Githubissues

amidaware / rmmagent

Tactical RMM Agent

https://github.com/amidaware/tacticalrmm

Other

129 stars 75 forks source link

initial SysTray PR #48

Closed conlan0 closed 2 months ago

conlan0 commented 6 months ago

This is windows support only
Added system tray icon with support for a menu with links and dividers and the support for submenus with links
Agent gets a nats signal every 5 mins to restart and update systray icon, name and config
Agent runs the systray on startup

conlan0 commented 6 months ago

To fix the failing tests we need to ensure the windows only stuff lives in files named something_windows.go and then stub the functions for linux/mac. You can stub them in agent_unix.go

got that done but i think theirs an issue where i import support in main.go here

'case "tray":

    if runtime.GOOS == "windows" {
        support.InitTrayIcon()
    }`

wh1te909 commented 6 months ago

I don't see any stubs. Look at https://github.com/amidaware/rmmagent/blob/b09eaf84de68dfb4f3cb6db6ff364a6745efd943/agent/agent_unix.go#L903 and you'll need to stub all the new systray related windows

conlan0 commented 6 months ago

okay got it. how do i update its packages now?

wh1te909 commented 6 months ago

You need to also add your go.mod and go.sum changes, I don't see those updated. When you installed that systray package on your local machine it would have updated these 2 files.

conlan0 commented 6 months ago

now its getting the download errors i do lol