search

amidaware / tacticalrmm

A remote monitoring & management tool, built with Django, Vue and Go.
https://docs.tacticalrmm.com
Other
2.92k stars 422 forks source link

Update agent_linux.sh #1809

Open dinger1986 opened 3 months ago

dinger1986 commented 3 months ago

changes for linux agents install

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 79.20%. Comparing base (0528ecb) to head (c00caf7).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #1809 +/- ## ======================================== Coverage 79.20% 79.20% ======================================== Files 138 138 Lines 9664 9664 ======================================== Hits 7654 7654 Misses 2010 2010 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dinger1986 commented 3 months ago

follows on from https://github.com/amidaware/tacticalrmm/pull/1796 which was removed as I needed to tidy up my repos

dinger1986 commented 1 month ago

change optional install dir

dinger1986 commented 1 month ago

@wh1te909 I can remove this line https://github.com/dinger1986/tacticalrmm/blob/c00caf7d11bcc4b4e8ee684914de23ca385ecd40/api/tacticalrmm/core/agent_linux.sh#L28 as it can be set by a variable, it was more to catch the instance where someone forgets to set it and then the binary doesnt get removed on uninstall. What I think Ill do is add it to PATH if its a custom folder and then use which to find it for uninstall, does that sound a good idea?

wh1te909 commented 1 month ago

@dinger1986 you need to make the appropriate changes in the agent code base, just like how we handle other optional install flags/settings

dinger1986 commented 1 month ago

Ah ok, I get you! I'll do some reading