Serverside actions and cli

[sadnub]

TODO/BUGS:

• [x] username missing top right
• [x] fix migrations (merge conflict)
• [x] crontab not being set
• [x] manually trying to run server side task (from global settings context menu) gives 500 error, frontend error Unable to run task: [object Object]
• [x] tools > bulk doesn't load, check console for error
• [x] permissions for web terminal
• [x] htop/top etc not working in web terminal in prod.
• [x] repeating characters in web terminal not working (type aaaa or bbbb or spam backspace) the fix is to move this into its own consumer, do not share with dash_info as the sleep is messing it up
• [x] move webhooks to their own UI (confusing because it's currently inside URL actions)
• [x] server script output doesn't show up in the alert manager like the regular scripts do
• [x] @sadnub figure out icon bug -use another icon if can't resolve
• [x] alert failure/resolved args/env vars not being saved
• [x] when creating new webhook, body of json is not being properly applied when switching between headers and body tab. fixed in https://github.com/amidaware/tacticalrmm-web/pull/18/commits/08edca4fbf9b4a989cdcb56854b28c0285c52087
• [x] hide and disable "Server Tasks" in global settings as this is not fully implemented
• [x] @wh1te909 handle "Timeout must be 60 or less" for server tasks
• [x] TOTP web UI setup broken Uncaught TypeError: Cannot read properties of undefined (reading 'then') at Proxy.logout (TOTPSetup.vue:79:9)
• [x] @wh1te909 Add auditing to new views and functions
• [x] Revert AddAutomatedTask.vue to previous version before rework
• [x] @wh1te909 Ensure webhook urls are encoded. Add test case.
• [x] @sadnub Add request body to the Test Webhooks modal
• [x] @sadnub Add loading indicator and error handling for Test Webhooks
• [x] Test web hooks feature does not substitute any variables, just None for everything. For example testing with {{agent.hostname}} returns None
• [x] https://github.com/amidaware/tacticalrmm/pull/1823#issuecomment-2070615363
• [x] https://github.com/amidaware/tacticalrmm/pull/1823#issuecomment-2070896055
• [x] @sadnub Alert webhook should not show up in agents context menu "Run Url Action" as well as in User Interface > URL Action
• [x] @wh1te909 Make web terminal open in new window, similar to remote background
• [x] @wh1te909 @dinger1986 @silversword411 Regression test all code that was reworked
• [x] @wh1te909 Add global setting to optionally disable web terminal and server scripts
• [x] @wh1te909 2FA code is not cleared after entering a wrong code on login screen

[silversword411]

Fix Pattern column, limit max length. Change bottom scrollbar to always show Test at browser with width 900

[dinger1986]

When building out content for the webhook message ie "text": "Error on {{agent.hostname}} with severity of {{alert.severity}}, at {{alert.alert_time}}. The full content of the message is {{alert.message}}" it doesnt send more than the first variable, same behaviour with teams and slack

[dinger1986]

Errors Running more advanced webhooks

POST

Header

{
    "Content-Type": "application/json",
    "User-Agent": "TacticalRMM/1.0"
}

Body

{
    "@type": "MessageCard",
    "@context": "http://schema.org/extensions",
    "summary": "Issue with {{agent.hostname}}",
    "themeColor": "0078D7",
    "title": "{{alert.message}}",
    "sections": [{
        "activityTitle": "Issue",
        "activitySubtitle": "On {{alert.severity}}",
        "facts": [{
            "name": "Alert Time",
            "value": "{{alert.alert_time}}"
        }],
        "markdown": true
    }]
}

I have DM'd the URL

Error from debug log

[22/Apr/2024 22:22:51] ERROR [log.py:log_response:241] Internal Server Error: /core/urlaction/run/test/
Traceback (most recent call last):
  File "/rmm/api/env/lib/python3.11/site-packages/django/core/handlers/exception.py", line 55, in inner
    response = get_response(request)
               ^^^^^^^^^^^^^^^^^^^^^
  File "/rmm/api/env/lib/python3.11/site-packages/django/core/handlers/base.py", line 197, in _get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/rmm/api/env/lib/python3.11/site-packages/django/views/decorators/csrf.py", line 56, in wrapper_view
    return view_func(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/rmm/api/env/lib/python3.11/site-packages/django/views/generic/base.py", line 104, in view
    return self.dispatch(request, *args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/rmm/api/env/lib/python3.11/site-packages/rest_framework/views.py", line 509, in dispatch
    response = self.handle_exception(exc)
               ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/rmm/api/env/lib/python3.11/site-packages/rest_framework/views.py", line 469, in handle_exception
    self.raise_uncaught_exception(exc)
  File "/rmm/api/env/lib/python3.11/site-packages/rest_framework/views.py", line 480, in raise_uncaught_exception
    raise exc
  File "/rmm/api/env/lib/python3.11/site-packages/rest_framework/views.py", line 506, in dispatch
    response = handler(request, *args, **kwargs)
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/rmm/api/tacticalrmm/core/views.py", line 454, in post
    result, _ = run_test_url_rest_action(
                ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/rmm/api/tacticalrmm/core/utils.py", line 308, in run_test_url_rest_action
    response = _run_url_rest_action(
               ^^^^^^^^^^^^^^^^^^^^^
  File "/rmm/api/tacticalrmm/core/utils.py", line 256, in _run_url_rest_action
    new_body = find_and_replace_db_values_dict(
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/rmm/api/tacticalrmm/core/utils.py", line 246, in find_and_replace_db_values_dict
    new_value = find_and_replace_db_values_str(text=value, instance=instance)
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/rmm/api/tacticalrmm/core/utils.py", line 225, in find_and_replace_db_values_str
    for string, model, prop in re.findall(RE_DB_VALUE, text):
                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/re/__init__.py", line 216, in findall
    return _compile(pattern, flags).findall(string)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: expected string or bytes-like object, got 'list'