amidaware / tacticalrmm

A remote monitoring & management tool, built with Django, Vue and Go.
https://docs.tacticalrmm.com
Other
2.92k stars 422 forks source link

[BUG]: Resolved Alerts are triggered after exiting maintenance mode #1849

Closed joeldeteves closed 2 days ago

joeldeteves commented 2 months ago

Server Info (please complete the following information):

Installation Method:

Agent Info (please complete the following information):

Describe the bug It seems like whenever we turn off maintenance mode we get a ton of “resolved” alerts.

We don’t get alerted during the window which is correct, but we get alerted for service restorations after the window is over, even if those services were resolved during the window.

This has been going on for as long as I remember, I just haven't had time to open an issue for it. I am confident every version of Tactical has done this, at least in our specific environment.

To Reproduce Steps to reproduce the behavior:

  1. Put a client in maintenance mode
  2. Trigger a reboot
  3. Exit maintenance mode (can be an hour later, it still does it)
  4. "Service Check: Resolved" gets triggered even though the service was started long before exiting maintenance mode

Expected behavior Maintenance mode should not trigger Resolved alerts after exiting maintenance mode.

Screenshots N/A

Additional context @wh1te909 is familiar with our environment. It is technically "unsupported" but nonetheless if it's something on our side, just need to know what the cause is so we can address and resolve accordingly. I am filing it as a bug report for now per conversation on Discord.

wh1te909 commented 2 months ago

can you paste screenshots of your alert policy settings just so I make sure I am replicating the issue properly

joeldeteves commented 2 months ago

Here you go:

trmm-alert-actions trmm-agent-overdue-settings trmm-check-settings

wh1te909 commented 3 weeks ago

Fixed in https://github.com/amidaware/tacticalrmm/pull/1823/commits/e6225ad2419bc93db45e9f50325cd46a3f89b2e3 will be in next release