amidaware / tacticalrmm

A remote monitoring & management tool, built with Django, Vue and Go.
https://docs.tacticalrmm.com
Other
3.23k stars 442 forks source link

Add Validation to Verify that Tasks Exist #1990

Open ZzBombardierzZ opened 2 months ago

ZzBombardierzZ commented 2 months ago

Is your feature request related to a problem? Please describe.

When using something like DeepFreeze, RebootRestore RX, Time Freeze, etc, tasks will be created once but then aren't validated ever again to make sure they still exist.

In DeepFreeze, Thawed means edits to the computer will be saved after the restart. If a machine is Frozen, it will not save any data changed after a reboot.

  1. Installed TRMM while DeepFreeze is Thawed.
  2. Enable DeepFreeze (Freeze the computer).
  3. Add a new task in TRMM admin webpage.
  4. Task seems to add and apply while the machine is Frozen.
  5. Machine reboots.
  6. Machine forgets the task was ever added.
  7. The machine never runs the task again.

In addition to the above, a user could simply delete a scheduled task from the Windows Task Scheduler, and I believe it would never be added/checked again? I'm not sure if you run the task manually if it re-adds it to the computer Task Scheduler or if it just runs it the one manual time.

Describe the solution you'd like Once a day (or more frequent), check if all the tasks assigned to the computer in Tactical are actually on the computer.

Describe alternatives you've considered A button in the computer's Tasks list to "Resync" tasks.

Or a task option to run the task from the server to the agent, instead of running from Windows Task Scheduler and then sending the results (agent to server). This would also support Mac and Linux in Tasks, but I imagine this is way more overhead on the server, and I also imagine the Mac and Linux Tasks coming soon will be implemented in another way.

Additional context In this screenshot, you can see one of the computers that have DeepFreeze on it. The actual results are worse than this Issue makes it seem, but my main concern from this write-up is what's happening with Highlighted / Orange circled one: "Synced with agent Awaiting output Has not run yet Monday, Wednesday, Friday at 01:50PM every 1 weeks".

image

wh1te909 commented 2 months ago

mac/linux task scheduling will be handled on the server, and eventually windows will be migrated to this as well as the current method has issues like this. in the meantime I can look into adding missing tasks back to the task scheduler