Array params have indexes now

amiel / ember-data-url-templates

an ember-addon to allow building urls with url templates instead of defining buildURL

https://github.com/amiel/ember-data-url-templates/wiki

MIT License

129 stars 22 forks source link

Array params have indexes now #47

Open samdemaeyer opened 6 years ago

samdemaeyer commented 6 years ago

Since the introduction of nested params, there seems to be something weird going on. The nested array params have now number inside. include[0]: 'Foo', include[1]: bar

I know it's this way because we cannot have duplicate keys in a javascript object, but would it be possible to go back to work with an array. Or is this intended behavior @amiel 😅 ?

Before: screenshot 2018-10-18 at 15 11 02

After: screenshot 2018-10-18 at 15 05 42

amiel commented 6 years ago

@samdemaeyer I'll admit that this was not intentional. I'm not sure how best to address it though.

I would gladly merge a fix if you have any ideas, so feel free to give it a shot. Otherwise I'm happy to look in to it, but I can't guarantee it will be any time soon.

amiel commented 5 years ago

I'm going to reopen this, as it is definitely still a bug, we just don't have a solution for it yet.