search

amietn / vcsi

Create video contact sheets, thumbnails
MIT License
491 stars 57 forks source link

Width is off by one #93

Open fireattack opened 3 years ago

fireattack commented 3 years ago

I tried two different video files (one 1080p, one 720p), with --width 1000, 1500, 2000. The generated thumbnail file is always off by one (999px, 1499px, 1999px.) All other settings are default.

OS: Windows FFMPEG version: ffmpeg version git-2020-08-16-5df9724

Version: efd73b30575ba56f8f90e706bf7ada8086fecd91 (newest master)

amietn commented 3 years ago

--width is confusing at the moment. What it does is more like --max-width.

In a previous version, vcsi generated contact sheets of the exact width specified with --width, however there was an issue which was fixed in https://github.com/amietn/vcsi/pull/50 by slightly changing the behavior of --width so that it acts as a maximum width that should not be exceeded.

Agreed, this is confusing and should be changed. I may add the previous functionality back into vcsi as an option at some point.