Drag and Drop bug in Odyssey's Bookmark Manager

[jens-maus]

@raziel- created the issue:

Summary

First of all, i'm not sure if this is Odyssey's fault or a bug in MUI.

In Odyssey's "Manage Bookmark" window one can drag and drop bookmarks around and they get automatically saved ot the bookmarks file.

There is an instance where one can erase a bookmark by accident by sending it into the void, which should not happen.

Steps to reproduce

1) Open Odyssey 2) Righ click to bring up the menu and choose the tab "Bookmarks" 3) Once there choose "Manage Bookmarks..." 4) Inside this window, if you have none, create some separators/links by using "Add Separator" (or add some links) 5) Now grab one separator/link and move it all the way up to your first entry right under "Title" 6) Move the saperator/link on the "line" underneath "Title" which separates the window elements

If you now move the separator/link to the right or left you will see the "dotted" line or lasso line come into view, which indicates where your separator/link will be placed.

7) Move the separator/link up so that i will be placed as very first entry in this list 8) Drop it and it will vanish

If it doesn't happen right away, try to cover the dotted line/lasso line with your dragged item completely so that it isn't visible and then drop your item.

Expected results

The dragged item should either be placed as entry number one on the very top of the list, like the dotted line/lasso line indicates or be dropped back to it's place where one picked it up.

Actual results

The entry is getting deleted, which is really bad.

Regression

I don't think so, i remember having this behaviour on older versions too, but was never able to reproduce it.

Notes

No idea what component i should blame it on. Using the MUI settings from the Bookmark window tells me (or does it?) it's not using NListtree for the Bookmarks window, nonetheless it *seems" to be another part of MUI (as i believe the GUI of Odyssey is completely MUI?).

Please feel free to correct me.

AmigaOS4 FE Update 1

[jens-maus]

@tboeckel commented:

So far I really have no clue what might be going wrong here or who may be at fault. Although Odyssey's bookmark listtree does some own stuff during DnD actions it is Listtree.mcc who does all the node rearrangements when the dragged node is dropped eventually.

[jens-maus]

@tboeckel uploaded file Listtree_21.5_debug.lha (159.7 KiB):

Listtree.mcc 21.5 debug version

[jens-maus]

@tboeckel commented:

Please try the attached debug version of Listtree.mcc. You will need to remove the ".debug" extension.

Please type this in a Shell before you run Odyssey:

setenv muidebug list

Furthermore you must run Sashimi to capture the debug output. All details about a debug version like this can be found in the FAQ. Then do the usual steps to let the issue happen. Finally attach the captured log here. I will try to find out what is going wrong then.

[jens-maus]

@raziel- uploaded file Sashimi.OUT (91.0 KiB):

log with only one link available

[jens-maus]

@raziel- commented:

First of all, thanks a lot for the quick response

installed the listtree.mcc (debug) - check setenv muidebug list - check sashimi > sashimi.out - check

I created a one line bookmark file so it doesn't get too big

Steps i did were:

1) Start Odyssey 2) Open up Bookmarks/Manage Bookmarks 3) Add Separator 4) D&D Separator from position 2 to position above the only link available, where it vanished into oblivion

log attached, hope it helps, if you need me more stuff to do, just shout

if you need me to attach a log with my huge bookmarks file, just shout (although it won't change a thing except the log being bigger)

EDIT: No memguard, i'm afraid...this program freezes my system on different occasions when running (need to write bug report to the os devs pronto)

[jens-maus]

@tboeckel changed status from new to assigned

[jens-maus]

@tboeckel changed component from undefined to Listtree.mcc

[jens-maus]

@tboeckel changed priority from undecided to normal

[jens-maus]

@tboeckel changed platform from AmigaOS4 to All

[jens-maus]

@tboeckel set owner to tboeckel

[jens-maus]

@tboeckel commented:

I just hacked up a small demo application and now I can confirm that the dragged node vanishes as soon as it is dropped to be moved above the first entry. So Listtree.mcc is the culprit here. I will investigate.

[jens-maus]

@tboeckel commented:

In amiga-mui/mui@8f925bc79ab52a69dff385eabe4bac9bbe87160f:

• mcc/Listtree.c: use the correct list when moving a treenode above the topmost treenode. This refs #322.

[jens-maus]

@tboeckel commented:

The next nightly build should fix this issue. Please try it and report back.

[jens-maus]

@raziel- commented:

Awesome, thanks a lot

Where can i find the nightly builds of listtree.mcc? Or do i have to install the whole MUI set?

[jens-maus]

@tboeckel commented:

Listtree.mcc is contained in the normal nightly builds of MUI, just like anything else.

Although Listtree.mcc is the only modified component so far since the release of 5.0-2016R3 I recommend to not mix up stuff of the nightly builds with the official releases.

[jens-maus]

@raziel- commented:

Tested Nightly Build and working

Thanks a lot

[jens-maus]

@tboeckel changed status from assigned to closed

[jens-maus]

@tboeckel set resolution to fixed