search

amiga-mui / muidev

:mage_man: Magic User Interface (MUI) – Documentation+Releases
http://muidev.de
55 stars 0 forks source link

Can't open menu when set "Enable embedded menu bar" #331

Closed samo79 closed 3 years ago

samo79 commented 3 years ago

I've originally reported it on the iGame repo

https://github.com/MrZammler/iGame/issues/144

Menu does not seems to work anymore in iGame if you set "Enable embedded menu bar" from MUI prefs ... options are showed in the main window but they can't be opened Tested with iGame 2.1 Beta 1 under AmigaOS 4.1 FE (latest MUI 5.0)

tboeckel commented 3 years ago

The menu might be built from Menu objects and Menuitem objects, but Menudisplay checked MUIA_Menu_Enabled only to be true. For Menuitem object this of course is never true and hence the item was considered to be disabled. Now the class is checked before the corresponding enabled state is checked.

Menudisplay_21_27_os3.zip Menudisplay_21_27_os4.zip

samo79 commented 3 years ago

Ok tested, but got a crash

Crashlog_iGame.OS4_2021-03-22_17-51-19.txt

samo79 commented 3 years ago

Crash is reproducible in all MUI applications, i've revert for now waiting for a proper implementation :-)

tboeckel commented 3 years ago

This crash seems to be related to some internal changes since 5.0-2020R3. The location of the crash is before the latest change...

tboeckel commented 3 years ago

We really need to get the nightly build up and running again :(

tboeckel commented 3 years ago

MUI-5.0-20210324-0d266f2-os4.zip

Please try this private nightly build for AmigaOS4.

samo79 commented 3 years ago

Yeah seems you fixed the issue at 100%, bravo :-) Ticket can be closed now..

About MUI development, frankly I was felt better with the old system .. apart from not being able to use the Amiga to report bugs (github does not work with Odyssey) it is not clear how we betatesters can follow its progress in details .... once the switch will be completed I hope that at least the periodically updated changelog file could be publicly available for reading/consulting ...