Window gadgets

[jens-maus]

Michael created the issue:

Problem

MUI window gadgets (Zoom, Snap. Menu, MUI...) are no longer patched properly by Visual Prefs.

Analysis

Cosmetic problem

Enhancement recommendation

If not possible to find a simple solution, maybe have an ENV variable, so that the gadgets are rendered using old code (for whom it is required)

Pictures show old MUI 3.8/3.9 and NEW MUI 3.9

[jens-maus]

Michael changed status from pending to new

[jens-maus]

Michael changed status from pending to new

[jens-maus]

Michael changed status from pending to new

[jens-maus]

Michael uploaded file MUI-NEW-GAD.PNG (10.2 KiB):

[jens-maus]

Michael uploaded file MUI_OLD.PNG (5.5 KiB):

[jens-maus]

@tboeckel changed priority from undecided to normal

[jens-maus]

@tboeckel changed status from new to closed

[jens-maus]

@tboeckel changed resolution from * to fixed*

[jens-maus]

@tboeckel commented:

The next nightly build should fix this issue partly. The "jump to screen" button is the big exception, because VisualPrefs doesn't know this button and hence cannot patch it.

[jens-maus]

Michael commented:

Regarding nightly builds... Can we have the debug less version ? Current AmigaOS3 archives are both with 10MB debug files.

[jens-maus]

@jens-maus commented:

No, debug is debug an nothing else. We need all debugging symbols there. And again you are mixing up things. This ticket is not about nightly builds, its about VisualPrefs. So please next time open another new ticket if you find that you want to have smaller debug archives.

[jens-maus]

Michael changed status from closed to reopened

[jens-maus]

Michael changed resolution from fixed to **

[jens-maus]

Michael commented:

Fixed partially in Nightly. Spacing is set wrongly for simple vector XEN style gadgets Also the screenjump gadget is currently a Dopus padlock, maybe it is better to use the next image TBRFRAMEIMAGE it will look empty in vector modes and can be anything in PXL GFX modes since it is unused at the moment.

[jens-maus]

Michael uploaded file MUI39N-window-gad.png (12.9 KiB):

Spacing problems

[jens-maus]

@tboeckel changed status from reopened to pending

[jens-maus]

@tboeckel commented:

MUI sets a fixed size for the images and gadgets. If a certain patch does not obey this fixed size and replaces the images by something smaller then it is the task of the patch to adjust the size and the position of the gadgets, too. VisualPrefs clearly fails to do this. Sorry, but it is not MUI's task to help bad patches doing their work correctly.

Maybe it is possible to obtain the size of the image right after creating the object to adjust the gadget's size. I will try this but I don't promise anything.

Furthermore I stated above already that the "jump to screen" button cannot be patches, because VisualPrefs doesn't know it. Either accept this fact or don't use this button. I used the padlock image just to show anything. I will revert that change again.

[jens-maus]

Michael commented:

Older MUI 3.8 and 3.9 had no problems with the size of the gadgets. 3.9 (2005) obviously had the screen button that could not be changed, and yes, it can be avoided since the function is in the popup menu anyway.

VisualPrefs has a reserved empty image, that can be used for a gadget that has no appropriate image as a fall back. And if you read the VP DEV docs they have gadget size parameters available. Also having fixed size gadgets is wrong, and this problem was slowly corrected since OS 2.1, and I believe in OS4 all gadgets have variable size setting.

Besides we are not inventing anything new, it used to work fine before, so it should not be a BIG problem to make it work again.

[jens-maus]

@tboeckel commented:

In amiga-mui/mui@79e7a45c3814fc13e1fcf399b98d9340dc3b4339:

• Winborder.c: don't let VisualPrefs replace the "jump to screen" button image because it doesn't know this image at all. This refs #44.

[jens-maus]

@tboeckel commented:

In amiga-mui/mui@14a220439bd4870c6335cfc6b99a3c2b3608a5bc:

• Winborder.c: ask the created image object for the image dimensions in case these differ from the desired dimensions. This refs #44.

[jens-maus]

Michael uploaded file MUI39N-2.PNG (4.4 KiB):

[jens-maus]

Michael uploaded file MUI39N-2-ZOOMED.png (6.7 KiB):

zoomed x4 version

[jens-maus]

Michael commented:

Almost there, but there is a 1 pxl miscalculation somewhere

.[[Image(MUI39N-2-ZOOMED.png​)]]

[jens-maus]

@tboeckel changed status from new to assigned

[jens-maus]

@tboeckel changed owner from * to tboeckel*

[jens-maus]

@tboeckel commented:

Please try again with the next nightly build. I added a few changes for the titlebar images in case VisualPrefs is active.

[jens-maus]

Michael uploaded file winborder-1.png (4.5 KiB):

[jens-maus]

Michael uploaded file winborder-2.png (5.0 KiB):

[jens-maus]

Michael uploaded file winborder-3.png (174.2 KiB):

[jens-maus]

Michael uploaded file winborder-3.2.png (61.3 KiB):

[jens-maus]

Michael commented:

[[Image(winborder-1.png)]] [[Image(winborder-2.png)]] [[Image(winborder-3.2.png)]] Previous version looked better (only 1 pxl of line) Here we get an empty gadget and the screen jump gadget really pops out of place if used, actually it looks as if it's position is static

But the iconify gadget is correct!

[jens-maus]

@tboeckel changed status from assigned to closed

[jens-maus]

@tboeckel changed resolution from * to fixed*

[jens-maus]

@tboeckel commented:

In amiga-mui/mui@7b00f9cf359dd9bdeed824ea043a6149b6d0c5f3:

• Winborder.c: derive the "winborderimage" class from "tbiclass" instead of "imageclass" if it is available. This makes it possible to add the yet unsupported screen jump image in a consistent way. This finally closes #44.

[jens-maus]

Michael uploaded file mui39-window2.png (43.0 KiB):

[jens-maus]

Michael commented:

[[Image(mui39-window2.png)]] Still open ;-)

Enforcer hit I guess is fixed....

The 'ghost' leftmost gadget appears when any additional gadget is enabled (it does not do anything). Also you can see that it is copied over the iconify gadget (backfill colour of gradient is wrong)

[jens-maus]

Michael changed status from closed to reopened

[jens-maus]

Michael changed resolution from fixed to **

[jens-maus]

@tboeckel changed status from reopened to pending

[jens-maus]

@tboeckel commented:

Did you check already with the latest nightly build (2014-07-26)? For me there is no additional gadget left of the popup gadget, no matter which setting I use for VisualPrefs.

Again, if you reopen a ticket then you must provide some new information. Otherwise we will close it again immediately.

[jens-maus]

Michael commented:

Latest build 2014-07-26, same story

[jens-maus]

@tboeckel commented:

In amiga-mui/mui@032a3f073a44d279caa2f3bf56e987dc77654d6a:

• Winborder.c: added some debug output to the window title gadget creation. This refs #44.

[jens-maus]

@tboeckel changed status from new to pending

[jens-maus]

@tboeckel commented:

Try again with the debug version of the next nightly build and creata a WINDOW debug log with it.

[jens-maus]

@tboeckel commented:

In amiga-mui/mui@1ad394deb519373f0c1b7bc456e610777f8dfd6a:

• Winborder.c: use TBFRAMEIMAGE as basis for the screen jump image in case VisualPrefs is running. This refs #44.

[jens-maus]

Michael commented:

Looks like it is working now! I am more or less happy with this now. Really further improvement requires update to VP.

However there are two small improvements/bugs potentially to be ironed out so.

1. For screenfonts below 13 (size 8-12) the window gadget width is a bit small for the current screenjump gadget image (it can be made a bit smaller by making the 3 small squares smaller by 1 pxl each) ideally it should be a vector image and size itself to the size of the window gadget.

2. When selecting the FUTURE look GUI design the screenjump gadget does not get the future look frame and remains flat.

But in reality, if it is not working for someone, the screenjump can be disabled.

[jens-maus]

@tboeckel commented:

Replying to [comment:20 Michael]:

1. For screenfonts below 13 (size 8-12) the window gadget width is a bit small for the current screenjump gadget image (it can be made a bit smaller by making the 3 small squares smaller by 1 pxl each) ideally it should be a vector image and size itself to the size of the window gadget.

It is some kind of vector image drawing itself from the center of the area with a width of 15 pixels. MUI itself assumes a width of 23 pixels while VisualPrefs uses 25 pixels. There is even a macro to calculate the position of a gadget within the frame which uses this 25 pixel width. As such there is plenty of space.

2. When selecting the FUTURE look GUI design the screenjump gadget does not get the future look frame and remains flat.

If VisualPrefs patches anything it is the task of VisualPrefs to make sure that everything is drawn correctl. If it fails to do this there is nothing I can do about that. However, I did another change yesterday which might fix this. Just try today's nightly build.

[jens-maus]

Michael commented:

The gadget width can be smaller, see top most pic above. For example with XEN.11 font and more or less square aspect ratio the gadget width is only 18 pixels (only 16 pixels left for the image) and ideally only 14 available for an image so that it does not touch the borders. With tiny fonts the window borders can get much smaller. So, can MUI detect the allowed width before calculating the image ? Currently, I guess it is fixed width, so for large fonts it will be a bit small.

[jens-maus]

Michael uploaded file mui39b-future-gadgets.png (59.9 KiB):

[jens-maus]

Michael commented:

[[Image(mui39b-future-gadgets.png​)]] The future mode is as is. And IMHO this can probably be fixed only with VP update. But the max width of the gadget image needs to be dynamic. Smaller for small gadgets, and a bit larger for ultra res screens