search

amiga-mui / thebar

Next generation MUI buttons bar custom class (TheBar.mcc) which provides application programmers with an advanced, high-level Toolbar-alike class.
GNU Lesser General Public License v2.1
12 stars 3 forks source link

Add support for ToolBar MCC class #7

Closed samo79 closed 4 years ago

samo79 commented 4 years ago

TheBar MCC could provide a sort of internal wrapper in order to support the older ToolBar MCC class and functionalities

Original report here: https://muidev.de/ticket/454

tboeckel commented 4 years ago

Can you provide some examples of applications which rely upon Toolbar.mcc? Please note, a wrapper class can only be an approximation of the real class provided the new base class offers the same features as the original class. So it might be possible that a wrapper class might be incomplete or might react differently than the original class.

samo79 commented 4 years ago

Sure, some software that quickly comes in my mind are:

AmiGift 2.1 MagicReader 0.46 AutoDocArt 1.031 eNote 1.6 AminetIdx 1.3

And various others.. all of them could be found on Aminet

About the wrapper: Yes I figured it wouldn't be easy... for this reason perhaps it would probably more logical (and easier) to just integrate the current Toolbar class into the MUI archive rather than breaking our head into writing a wrapper from scratch which we should then betatest aniway... :-)

tboeckel commented 4 years ago

We already have a working toolbar class. I am not going to implement yet another one. A wrapper is much easier to do than having to deal with all the low level details like loading images, etc.

tboeckel commented 4 years ago

Toolbar_26.1_os3.zip Toolbar_26.1_os4.zip Test binaries for AmigaOS3 and AmigaOS4

samo79 commented 4 years ago

Indeed, for this reason I imagined that it would be better to integrate the class as it was, rather than making a wrapper :-) Aniway as it seems you did that already i will test it, thanks a lot Thore :-)

samo79 commented 4 years ago

Ok i've started some test, tried an heavy one (AmiGift 2.0) and all goes well. Atleast no issue for now.. :-) Will test some more programs in the coming days/weeks

Just a question, maybe we will need also the related Toolbar.mcp ? If not from where we can eventually configure the things

tboeckel commented 4 years ago

Well, since the new Toolbar.mcc is just a wrapper around TheBar.mcc all the configuration is of course done with TheBar.mcp.

samo79 commented 4 years ago

Ah ok, so i presume the real "compatibility test" to do will be there