search

amihaiemil / comdor

Your ship's DevOps Commodore.
http://comdor.co
BSD 3-Clause "New" or "Revised" License
10 stars 0 forks source link

Disconnected Docker client and refactoring #86

Closed amihaiemil closed 6 years ago

amihaiemil commented 6 years ago

Fixes #84

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-11.1%) to 62.552% when pulling 93ba5442ac3dd4c331f17d9227887139145a830b on 84 into 12d8cd46c721a48940f27e88a4bbb440cba41514 on master.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-11.1%) to 62.552% when pulling 5483991158d703384ae0cace7abd754dc6483a98 on 84 into 12d8cd46c721a48940f27e88a4bbb440cba41514 on master.

coveralls commented 6 years ago

Coverage Status

Coverage increased (+4.1%) to 77.809% when pulling 3d166e34362a1659e5766e4ba67e781b2ad10d88 on 84 into 12d8cd46c721a48940f27e88a4bbb440cba41514 on master.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-11.1%) to 62.552% when pulling e79b989faac23a08ed7d9dac64db3c253ed9432d on 84 into 12d8cd46c721a48940f27e88a4bbb440cba41514 on master.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-11.1%) to 62.552% when pulling 528d3b6ef5a3d81085c04787e7c8eccfe19a0bfb on 84 into 12d8cd46c721a48940f27e88a4bbb440cba41514 on master.

coveralls commented 6 years ago

Coverage Status

Coverage increased (+1.3%) to 75.0% when pulling 5b245a20bcb7be140641cc7dc6631721fe6979f7 on 84 into 12d8cd46c721a48940f27e88a4bbb440cba41514 on master.

amihaiemil commented 6 years ago

the test works fine, but co.comdor.Disconnected is excluded from the coverage report because apparently jacoco doesn't "see" reflection tests

amihaiemil commented 6 years ago

@rultor merge it

rultor commented 6 years ago

@rultor merge it

@amihaiemil OK, I'll try to merge now. You can check the progress of the merge here

rultor commented 6 years ago

@rultor merge it

@amihaiemil Done! FYI, the full log is here (took me 2min)