amihaiemil / docker-java-api

Lightweight Java Docker client
BSD 3-Clause "New" or "Revised" License
270 stars 53 forks source link

For #230: Extend RegistryConfigAuth to support multiple registries #247

Closed paulodamaso closed 5 years ago

paulodamaso commented 5 years ago

For #230: Extend RegistryConfigAuth to support multiple registries

0crat commented 5 years ago

Job #247 is now in scope, role is REV

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 436


Totals Coverage Status
Change from base Build 431: 0.06%
Covered Lines: 579
Relevant Lines: 673

💛 - Coveralls
coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 436


Totals Coverage Status
Change from base Build 431: 0.06%
Covered Lines: 579
Relevant Lines: 673

💛 - Coveralls
0crat commented 5 years ago

This pull request #247 is assigned to @paulodamaso/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @amihaiemil/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be no monetary reward for this job

paulodamaso commented 5 years ago

@amihaiemil Auto assigned to me, please take a look

0crat commented 5 years ago

@paulodamaso/z this job was assigned to you 5days ago. It will be taken away from you soon, unless you close it, see §8. Read this and this, please.

amihaiemil commented 5 years ago

@rultor merge it

rultor commented 5 years ago

@rultor merge it

@amihaiemil OK, I'll try to merge now. You can check the progress of the merge here

rultor commented 5 years ago

@rultor merge it

@amihaiemil Done! FYI, the full log is here (took me 2min)

0crat commented 5 years ago

The job #247 is now out of scope

0crat commented 5 years ago

Order was finished: +15 point(s) just awarded to @paulodamaso/z

0crat commented 5 years ago

Job gh:amihaiemil/docker-java-api#247 doesn't exist in WBS, can't create order

0crat commented 5 years ago

Payment to ARC for a closed pull request, as in §28: +10 point(s) just awarded to @amihaiemil/z