amihaiemil / docker-java-api

Lightweight Java Docker client
BSD 3-Clause "New" or "Revised" License
270 stars 53 forks source link

For #243: Adding filters to FilteredUriBuilder #253

Closed bkuzmic closed 5 years ago

bkuzmic commented 5 years ago

For #243:

0crat commented 5 years ago

Job #253 is now in scope, role is REV

0crat commented 5 years ago

This pull request #253 is assigned to @paulodamaso/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @amihaiemil/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be no monetary reward for this job

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 446


Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/com/amihaiemil/docker/FilteredUriBuilder.java 11 13 84.62%
<!-- Total: 15 17 88.24% -->
Totals Coverage Status
Change from base Build 444: 0.4%
Covered Lines: 614
Relevant Lines: 706

💛 - Coveralls
paulodamaso commented 5 years ago

@rultor merge

amihaiemil commented 5 years ago

@rultor merge it

rultor commented 5 years ago

@rultor merge

@paulodamaso Thanks for your request. @amihaiemil Please confirm this.

rultor commented 5 years ago

@rultor merge it

@amihaiemil @bkuzmic The pull request is closed already, so I can't merge it

rultor commented 5 years ago

@rultor merge it

@amihaiemil I'm sorry, I don't understand you :( Check this page and try again please

0crat commented 5 years ago

Job was finished in 22 hours, bonus for fast delivery is possible (see §36)

0crat commented 5 years ago

The job #253 is now out of scope

0crat commented 5 years ago

Order was finished: +20 point(s) just awarded to @paulodamaso/z

0crat commented 5 years ago

Payment to ARC for a closed pull request, as in §28: +10 point(s) just awarded to @amihaiemil/z