search

amihaiemil / docker-java-api

Lightweight Java Docker client
BSD 3-Clause "New" or "Revised" License
270 stars 53 forks source link

For #244 Adding User Agent Request Header as interceptor #261

Closed bkuzmic closed 5 years ago

bkuzmic commented 5 years ago

For #244:

0crat commented 5 years ago

Job #261 is now in scope, role is REV

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 463

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/com/amihaiemil/docker/SslHttpClient.java 0 2 0.0%
<!-- Total: 5 7 71.43% -->
Totals Coverage Status
Change from base Build 461: -0.05%
Covered Lines: 676
Relevant Lines: 757
💛 - Coveralls
coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 463

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/com/amihaiemil/docker/SslHttpClient.java 0 2 0.0%
<!-- Total: 5 7 71.43% -->
Totals Coverage Status
Change from base Build 461: -0.05%
Covered Lines: 676
Relevant Lines: 757
💛 - Coveralls
0crat commented 5 years ago

This pull request #261 is assigned to @paulodamaso/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @amihaiemil/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be a monetary reward for this job

amihaiemil commented 5 years ago

@bkuzmic looks good, thanks :)

amihaiemil commented 5 years ago

@rultor merge it

rultor commented 5 years ago

@rultor merge it

@amihaiemil OK, I'll try to merge now. You can check the progress of the merge here

rultor commented 5 years ago

@rultor merge it

@amihaiemil Done! FYI, the full log is here (took me 2min)

0crat commented 5 years ago

Job was finished in 1 hours, bonus for fast delivery is possible (see §36)

0crat commented 5 years ago

Quality is low, no payment, see §31:

0crat commented 5 years ago

The job #261 is now out of scope

0crat commented 5 years ago

Payment to ARC for a closed pull request, as in §28: +10 point(s) just awarded to @amihaiemil/z