For #213 Creating volumes with parameters

amihaiemil / docker-java-api

Lightweight Java Docker client

BSD 3-Clause "New" or "Revised" License

270 stars 53 forks source link

For #213 Creating volumes with parameters #262

Closed bkuzmic closed 5 years ago

bkuzmic commented 5 years ago

For #213:

creating volumes with parameters like driver, driver options and labels
also returning proper Volume object on create.

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 467

16 of 16 (100.0%) changed or added relevant lines in 1 file are covered.
3 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.05%) to 89.398%

Files with Coverage Reduction	New Missed Lines	%
src/main/java/com/amihaiemil/docker/SslHttpClient.java	3	12.5%
<!--	Total:	3		-->

Totals
Change from base Build 461:	0.05%
Covered Lines:	683
Relevant Lines:	764

💛 - Coveralls

0crat commented 5 years ago

Job #262 is now in scope, role is REV

0crat commented 5 years ago

This pull request #262 is assigned to @bkuzmic/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @amihaiemil/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be a monetary reward for this job

bkuzmic commented 5 years ago

@amihaiemil Is this a 0crat bug? I am asked to do the review of my own PR :)

amihaiemil commented 5 years ago

@bkuzmic seems like it, yes. Can you submit it to zerocrat/farm? You should get paid if you are a member there :)

bkuzmic commented 5 years ago

@amihaiemil I think somebody already submitted it to zerocrat/farm. I'm not a member, so feel free to do it if you want. What we can do about this issue?

bkuzmic commented 5 years ago

@amihaiemil I still want to add a negative test case for create to fix the coverage.

amihaiemil commented 5 years ago

@bkuzmic sure, go ahead with the test.

We will just merge this PR without REV... it happened before too, it shouldn't be a problem.

bkuzmic commented 5 years ago

@rultor merge it.

rultor commented 5 years ago

@rultor merge it.

@bkuzmic Thanks for your request. @amihaiemil Please confirm this.

amihaiemil commented 5 years ago

@rultor good to merge

rultor commented 5 years ago

@rultor good to merge

@amihaiemil OK, I'll try to merge now. You can check the progress of the merge here

rultor commented 5 years ago

@rultor good to merge

@amihaiemil Done! FYI, the full log is here (took me 2min)

0crat commented 5 years ago

Job was finished in 1 hours, bonus for fast delivery is possible (see §36)

0crat commented 5 years ago

The project doesn't have enough funds, can't make a payment

0crat commented 5 years ago

The job #262 is now out of scope

0crat commented 5 years ago

Order was finished: +20 point(s) just awarded to @bkuzmic/z

0crat commented 5 years ago

The project doesn't have enough funds, can't make a payment

0crat commented 5 years ago

Payment to ARC for a closed pull request, as in §28: +10 point(s) just awarded to @amihaiemil/z