amihaiemil / docker-java-api

Lightweight Java Docker client
BSD 3-Clause "New" or "Revised" License
270 stars 53 forks source link

For #269: Implementing Plugin enable() and disable() methods #279

Closed bkuzmic closed 5 years ago

bkuzmic commented 5 years ago

For #269:

0crat commented 5 years ago

Job #279 is now in scope, role is REV

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 492


Totals Coverage Status
Change from base Build 491: 0.6%
Covered Lines: 768
Relevant Lines: 855

💛 - Coveralls
coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 492


Totals Coverage Status
Change from base Build 491: 0.6%
Covered Lines: 768
Relevant Lines: 855

💛 - Coveralls
0crat commented 5 years ago

This pull request #279 is assigned to @paulodamaso/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @amihaiemil/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be no monetary reward for this job

amihaiemil commented 5 years ago

@bkuzmic looks good, thanks! :)

amihaiemil commented 5 years ago

@rultor merge it

rultor commented 5 years ago

@rultor merge it

@amihaiemil OK, I'll try to merge now. You can check the progress of the merge here

rultor commented 5 years ago

@rultor merge it

@amihaiemil @bkuzmic Oops, I failed. You can see the full log here (spent 20s)

+ set -e
+ set -o pipefail
++ dirname ./run.sh
+ cd .
+ echo 19720
+ echo '1.68.1 24dc2a841'
1.68.1 24dc2a841
+ date
Wed Jan  9 09:58:23 CET 2019
+ uptime
 09:58:23 up 25 days, 28 min,  0 users,  load average: 5.56, 5.98, 6.17
+ ff=default
+ image=yegor256/java8
+ rebase=false
+ head_branch=master
+ pull_title='For #269: Implementing Plugin enable() and disable() methods'
+ author=amihaiemil
+ directory=
+ head=git@github.com:amihaiemil/docker-java-api.git
+ pull_id=279
+ fork=git@github.com:bkuzmic/docker-java-api.git
+ fork_branch=issue-269-RtPlugin-Enable-Disable
+ squash=false
+ vars=('--env=MAVEN_OPTS=-XX:MaxPermSize=256m -Xmx1g' '--env=head=git@github.com:amihaiemil/docker-java-api.git' '--env=pull_id=279' '--env=fork=git@github.com:bkuzmic/docker-java-api.git' '--env=fork_branch=issue-269-RtPlugin-Enable-Disable' '--env=head_branch=master' '--env=pull_title=For #269: Implementing Plugin enable() and disable() methods' '--env=author=amihaiemil' '--env=scripts=( '\''export '\''\'\'''\''MAVEN_OPTS=-XX:MaxPermSize=256m -Xmx1g'\''\'\'''\'''\'' '\'';'\'' '\''export '\''\'\'''\''head=git@github.com:amihaiemil/docker-java-api.git'\''\'\'''\'''\'' '\'';'\'' '\''export '\''\'\'''\''pull_id=279'\''\'\'''\'''\'' '\'';'\'' '\''export '\''\'\'''\''fork=git@github.com:bkuzmic/docker-java-api.git'\''\'\'''\'''\'' '\'';'\'' '\''export '\''\'\'''\''fork_branch=issue-269-RtPlugin-Enable-Disable'\''\'\'''\'''\'' '\'';'\'' '\''export '\''\'\'''\''head_branch=master'\''\'\'''\'''\'' '\'';'\'' '\''export '\''\'\'''\''pull_title=For #269: Implementing Plugin enable() and disable() methods'\''\'\'''\'''\'' '\'';'\'' '\''export '\''\'\'''\''author=amihaiemil'\''\'\'''\'''\'' '\'';'\'' '\''mvn clean install -Pcheckstyle'\'' '\'';'\'' )')
+ scripts=('export '\''MAVEN_OPTS=-XX:MaxPermSize=256m -Xmx1g'\''' ';' 'export '\''head=git@github.com:amihaiemil/docker-java-api.git'\''' ';' 'export '\''pull_id=279'\''' ';' 'export '\''fork=git@github.com:bkuzmic/docker-java-api.git'\''' ';' 'export '\''fork_branch=issue-269-RtPlugin-Enable-Disable'\''' ';' 'export '\''head_branch=master'\''' ';' 'export '\''pull_title=For #269: Implementing Plugin enable() and disable() methods'\''' ';' 'export '\''author=amihaiemil'\''' ';' 'mvn clean install -Pcheckstyle' ';')
+ container=amihaiemil_docker-java-api_279
+ as_root=false
+ mkdir -p /home/rultor/.ssh
+ echo -e 'Host github.com\n\tStrictHostKeyChecking no\n'
+ chmod 600 /home/rultor/.ssh/config
+ git clone git@github.com:amihaiemil/docker-java-api.git repo
Cloning into 'repo'...
+ cd repo
+ git config user.email me@rultor.com
+ git config user.name rultor
+ '[' -z 'export '\''MAVEN_OPTS=-XX:MaxPermSize=256m -Xmx1g'\''' ']'
+ cd ..
+ cat
+ '[' false = true ']'
+ cat
+ chmod a+x entry.sh
+ cat
+ echo 'export '\''MAVEN_OPTS=-XX:MaxPermSize=256m -Xmx1g'\''' ';' 'export '\''head=git@github.com:amihaiemil/docker-java-api.git'\''' ';' 'export '\''pull_id=279'\''' ';' 'export '\''fork=git@github.com:bkuzmic/docker-java-api.git'\''' ';' 'export '\''fork_branch=issue-269-RtPlugin-Enable-Disable'\''' ';' 'export '\''head_branch=master'\''' ';' 'export '\''pull_title=For #269: Implementing Plugin enable() and disable() methods'\''' ';' 'export '\''author=amihaiemil'\''' ';' 'mvn clean install -Pcheckstyle' ';'
+ sensitive=()
+ gpgconf --reload gpg-agent
+ gpg --keyserver hkp://pool.sks-keyservers.net --verbose --recv-keys 9AF0FA4C
gpg: requesting key 9AF0FA4C from hkp server pool.sks-keyservers.net
gpgkeys: key 9AF0FA4C can't be retrieved
gpg: no valid OpenPGP data found.
gpg: Total number processed: 0
gpg: keyserver communications error: keyserver helper general error
gpg: keyserver communications error: unknown pubkey algorithm
gpg: keyserver receive failed: unknown pubkey algorithm
'cid' file is absent, container wasn't started correctly
0crat commented 5 years ago

Job was finished in 21 hours, bonus for fast delivery is possible (see §36)

0crat commented 5 years ago

Quality is low, no payment, see §31:

0crat commented 5 years ago

The job #279 is now out of scope

0crat commented 5 years ago

Payment to ARC for a closed pull request, as in §28: +10 point(s) just awarded to @amihaiemil/z