search

amikha1lov / RecApp

User friendly Open Source screencaster for Linux written in GTK. Using free GStreamer modules and not depend on FFmpeg.
GNU General Public License v3.0
117 stars 20 forks source link

Remove xdg-user-dirs and xdg-utils dependencies #79

Closed mathiascode closed 3 years ago

mathiascode commented 3 years ago

As the title says.

@SeaDve Could you check if this change improves https://github.com/amikha1lov/RecApp/issues/67?

SeaDve commented 3 years ago

As the title says.

@SeaDve Could you check if this change improves #67?

I think yes! It is much faster and so far it hasn't failed. Although if it opens file other from the Videos folder it is still failing, could be flatpak permissions issue?

mathiascode commented 3 years ago

Looks like it's exclusive to the Flatpak build. I'll investigate.

mathiascode commented 3 years ago

I was scratching my head on https://github.com/amikha1lov/RecApp/issues/67 for a while. Turns out it's a regression in xdg-desktop-portal. https://github.com/flatpak/xdg-desktop-portal/issues/545

SeaDve commented 3 years ago

I found a fix to this (not very ideal solution) I'll push it on my seadve branch

SeaDve commented 3 years ago

I realized that this could also cause issues when saving the video since we are storing the saving location directory. When you restart your pc, it will have different inode numbers and fail to save the recording.