search

amikha1lov / RecApp

User friendly Open Source screencaster for Linux written in GTK. Using free GStreamer modules and not depend on FFmpeg.
GNU General Public License v3.0
116 stars 20 forks source link

Replace GtkFileChooserButton with custom implementation for GTK4 #80

Closed mathiascode closed 3 years ago

mathiascode commented 3 years ago

GtkFileChooserButton was removed in GTK4. https://developer.gnome.org/gtk4/unstable/ch41s02.html#id-1.7.4.4.85

In another project I currently maintain, I noticed that our numerous GtkFileChooserButton widgets were responsible for large slowdowns on initial load. This PR may help with https://github.com/amikha1lov/RecApp/issues/73, although the difference should be quite small, as there's only one button in this app.

Closes https://github.com/amikha1lov/RecApp/issues/71

SeaDve commented 3 years ago

A suggestion relate to #81 is to show the message as they select a inappropriate folder instead of when it starts recording, maybe?

Also it would be great to move the class to its own file. (I already remove the aboutdialog class on my branch)