search

amikha1lov / RecApp

User friendly Open Source screencaster for Linux written in GTK. Using free GStreamer modules and not depend on FFmpeg.
GNU General Public License v3.0
116 stars 20 forks source link

1.1.1: test suite is failing #89

Closed kloczek closed 3 years ago

kloczek commented 3 years ago 
+ /usr/bin/meson test -C noarch-redhat-linux-gnu --num-processes 48 --print-errorlogs
ninja: Entering directory `/home/tkloczko/rpmbuild/BUILD/RecApp-1.1.1/noarch-redhat-linux-gnu'
ninja: no work to do.
1/3 Validate desktop file          OK              0.02s
2/3 Validate schema file           OK              0.01s
3/3 Validate appstream file        FAIL            0.31s   exit status 1
>>> MALLOC_PERTURB_=201 /usr/bin/appstream-util validate data/com.github.amikha1lov.RecApp.appdata.xml
――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――― ✀  ―――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――
stdout:
data/com.github.amikha1lov.RecApp.appdata.xml: FAILED:
• style-invalid         : <image> has vertical padding [https://raw.githubusercontent.com/amikha1lov/RecApp/master/RecApp-screenshot.png]
• style-invalid         : <image> has horizontal padding [https://raw.githubusercontent.com/amikha1lov/RecApp/master/RecApp-screenshot.png]
stderr:
Validation of files failed
――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――

Summary of Failures:

3/3 Validate appstream file FAIL            0.31s   exit status 1
SeaDve commented 3 years ago

https://github.com/amikha1lov/RecApp/pull/88/commits/11826292786dd021badc5272c31198a3c1406054 should fix this

kloczek commented 3 years ago

Yep that works:

$ rpmbuild -ba --clean --rmsource --rmspec sqlite.spec &
warning: Downloading https://github.com/amikha1lov/recapp//commit/11826292.patch#/recapp-relax-appstream-util-validation-test.patch to /home/tkloczko/rpmbuild/SOURCES/recapp-relax-appstream-util-validation-test.patch

[..]

+ /usr/bin/meson test -C noarch-redhat-linux-gnu --num-processes 48 --print-errorlogs
ninja: Entering directory `/home/tkloczko/rpmbuild/BUILD/RecApp-1.1.1/noarch-redhat-linux-gnu'
ninja: no work to do.
1/3 Validate desktop file          OK              0.02s
2/3 Validate schema file           OK              0.01s
3/3 Validate appstream file        OK              0.14s

However I'm not sure is it correct approach relaxing validatio but to be honest I don;t know to much about those appstream files :P

Thx. Closing.

SeaDve commented 3 years ago

Appstream validation is too strict that it doesn't allow transparent background on the borders of the screenshot.