search

amilajack / falcon-core-old

The cross-database ORM that powers falcon
MIT License
2 stars 1 forks source link

PR: Query timing #20

Open amilajack opened 7 years ago

amilajack commented 7 years ago

The timing of each query needs to be returned with all the results. Determine which method is appropriate to expose this information. Just make sure the method is a user facing (public) API. The timing should be attached to the response object of this method. The time should be given in ms and as a number as opposed to a string. The timing should only reflect the timing of the query and not the timing of the javascript runtime. Don't use how long the function takes to execute as the timing. Instead, measure only the execution time of the query. The appropriate tests should be added along with this PR.

Example response:

type getResults = () => ({
  data: Array<{...}>,
  timing: {
    ms: 2000
    s: 2000
  }
})

Resources: How to Measure Execution Time in Node.js

NOTE: Couldn't get async to work with this