amilajack / popcorn-time-desktop

🍿 🕐 🎞 A Modern Popcorn Time Client
MIT License
468 stars 109 forks source link

upgrade electron to v5 #559

Closed amilajack closed 5 years ago

amilajack commented 5 years ago

This is complicated because mdns is a native dependency which depends on an older version of the v8 API. Either the dependency itself needs to be updated to account for the changes in the v8 API or we can migrate to another API. I'm currently working on a major refactoring of the mdns related logic here. Also note that ffmpeg must be upgraded as well when bumping the electron version.