No need for ternary for element render - Githubissues

amilajack / popcorn-time-desktop

🍿 🕐 🎞 A Modern Popcorn Time Client

MIT License

468 stars 109 forks source link

No need for ternary for element render #564

Closed pedroabreu closed 5 years ago

pedroabreu commented 5 years ago

Pull request name

Pre-Submission Checklist

[ ] Your pull request targets the master branch.
[ ] Branch starts with either fix/ or feature/ (e.g. fix/signin-issue)
[ ] All new and existing tests pass.

Type of Change

[ ] Small bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds new functionality)
[ ] Breaking change (fix or feature that would change existing functionality)

Checklist:

[ ] Tested changes locally.
[ ] Closes currently open issue (replace XXXX with an issue no): Closes #XXXX

Description

Half way trough the change I realized this might me more a matter of personal preference, as it's not actually wrong. Personally I think it adds a bit more noise, when ready the code (pretty much what I'm doing now).