search

amilajack / popcorn-time-desktop

🍿 🕐 🎞 A Modern Popcorn Time Client
MIT License
468 stars 109 forks source link

Tidy/Item component #573

Closed pedroabreu closed 5 years ago

amilajack commented 5 years ago

Thank you so much for the awesome PRs! I was wondering if you would be interested in working on https://github.com/amilajack/popcorn-time-desktop/issues/282. This bug causes a terrible user experience, especially when you're scrolling through many pages of movies, click on a movie, and then click the back button and then have to scroll all the way down again.

amilajack commented 5 years ago

This seems to have introduce a small bug with the torrent seeder count color. This should be green:

Screen Shot 2019-04-21 at 3 44 03 PM
pedroabreu commented 5 years ago

Logic is the same for the icon color 🤔 Is it possible it was already there ? Only thing I can think of is that the health property doesn't respect the expected string values

amilajack commented 5 years ago

It might have been there already. May have been introduced by https://github.com/amilajack/popcorn-time-desktop/pull/575.

pedroabreu commented 5 years ago

I think it's even before that. It's related to the way the health is set, depending on ratio and not just number of seeders.

So, if the ratio is < 1, it will always set poor quality, regardless of the number of seeders

amilajack commented 5 years ago

I fixed it yesterday. Turned out to be a small typo