search

amillb / pgMapMatch

map-matching of GPS traces
MIT License
77 stars 20 forks source link

mapMatcher.matchGPXTrace() requires a GPX file path #23

Closed ctchervenkov closed 2 years ago

ctchervenkov commented 2 years ago

The mapMatcher.matchGPXTrace(fn) method requires a filename to be passed. However, one might not want to write out a GPX file for each GPS trace, but simply generate a GPX object on the fly which then can be processed.

amillb commented 2 years ago

If there's a use case for this, feel free to open a pull request. Same with #22

ctchervenkov commented 2 years ago

Normally, I would have created a branch, push my fix there, and then submitted the pull request to master. However, I am restricted from doing so. Do you instead want people to fork the repo, make changes there and submit the pull request from the fork?

amillb commented 2 years ago

I added you as a collaborator. I hadn't paid much attention to the access settings TBH.

ctchervenkov commented 2 years ago

Thank you!

Chris

Sent from my iPhone

On 18 Oct 2021, at 16:30, Adam Millard-Ball @.***> wrote:

 I added you as a collaborator. I hadn't paid much attention to the access settings TBH.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

amillb commented 2 years ago

Looks great @ctchervenkov. Thanks for the addition.