Closed sbellem closed 6 years ago
This reminds me that zfec
will also be a dependency of honeybadger-go. Maybe the solution in either case will be to give zfec
an interface so it can be called from a separate process?
This reminds me that zfec will also be a dependency of honeybadger-go. Maybe the solution in either case will be to give zfec an interface so it can be called from a separate process?
I'm not sure what's the best approach for Go. I guess that ideally you would want a Go implementation of zfec, but time wise that is probably not ideal.
As for Python I just noticed that there was already a PR for Python 3 support (https://github.com/tahoe-lafs/zfec/pull/4) and it is not so big. So I would prefer helping with getting this PR through, assuming that there's not too much work left to be done :smile: !
UPDATE: Python 3 only port is under branch https://github.com/sbellem/HoneyBadgerBFT/tree/python3-port
All tests are passing, and the coverage is at 79%.
Things that are left to do (see Porting Python 2 Code to Python 3 for help):
setup.py
This is fantastic work, thanks for being so systematic and looking into the zfec dependency especially. I appreciate that you set up the dependency link in the meantime to your own fork while also nudging them to merge the pull request!
I would be happy to adopt python3 even without maintaining python2 compatibility for this.
Thanks to @tpltnt, pyutil now supports Python 3! This is a step forward for the zfec PR: https://github.com/tahoe-lafs/zfec/pull/4#issuecomment-357302645.
This is a step forward for the zfec PR: tahoe-lafs/zfec#4 (comment).
zfec
now supports Python 3.
Closing as it was handled in initc3/HoneyBadgerBFT-Python#3
Given the various specialized dependencies, especially the cryptographic ones, this issue is simply concerned with evaluating how feasible it would be to port HoneyBadgerBFT to Python 3 in a reasonable time frame.
The result of the evaluation will be documented here in this issue.
blockers
UPDATE: No more blockers.
zfec
now supports Python 3 -- PR https://github.com/tahoe-lafs/zfec/pull/4 was merged.zfec
does not support Python 3 at the moment (related issue: https://github.com/tahoe-lafs/zfec/issues/1)There's a PR :smile: --> https://github.com/tahoe-lafs/zfec/pull/4 !Dependencies
gevent
gmpy2
pysocks
zfec
Charm-Crypto
ecdsa
gipc
pycrypto
Notes
Some details to watch out for.
charm-crypto
The latest
charm-crypto
cannot be installed simply withpip
as there is an error when setting config values. This can be worked around by cloning the repo and performing the configuration to create a config file and running make, and then pip installing. So not a big deal, but inconvenient.pycrypto
Latest commit https://github.com/dlitz/pycrypto/commit/7acba5f3a6ff10f1424c309d0d34d2b713233019 on Jun 20, 2014
50 opened pull requests (https://github.com/dlitz/pycrypto/pulls)
111 opened issues (https://github.com/dlitz/pycrypto/issues)
[ ] Figure out what's up with the project.