amiller / HoneyBadgerBFT

The Honey Badger of BFT Protocols

Other

314 stars 84 forks source link

Allow the coverage to drop by 1% #55

Closed sbellem closed 6 years ago

sbellem commented 6 years ago

At least for the time being, that should help dealing with PRs that somehow fail, because of 0.10 % coverage decreases meanwhile no actual implementation code was modified.

Based on https://docs.codecov.io/docs/commit-status#section-threshold.

codecov-io commented 6 years ago

Codecov Report

Merging #55 into dev will decrease coverage by 0.10752%. The diff coverage is n/a.

@@                 Coverage Diff                 @@
##                 dev         #55         +/-   ##
===================================================
- Coverage   68.60214%   68.49462%   -0.10753%     
===================================================
  Files             18          18                 
  Lines            930         930                 
===================================================
- Hits             638         637          -1     
- Misses           292         293          +1

sbellem commented 6 years ago

This can be merged before #53 and #54. Will then rebase both PRs so that the coverage problem does not occur.

sbellem commented 6 years ago

Closing as it is superseded by #58.