amilner42 / code-tidbit

Share Programming Knowledge Better
GNU General Public License v3.0
9 stars 1 forks source link

128 bigbit fs #151

Closed amilner42 closed 7 years ago

amilner42 commented 7 years ago

Closes

Closes #128

Description

Bigbit FS now set up to open on the left just like in an editor. It is actually used as the default option to make users aware, but you can close it if you have a smaller screen and don't want to keep the editor open.

The UX on the view bigbit page had to change because it had a bunch of logic about what was open and what was allowed to be open (because the FS sat on top of the comments). The new UX is catered to what I believe to be the most common flow:

You can also click on the progress bar now when viewing bigbits/snipbits to recenter on that frame.

Additionally

Progress bar made much cleaner, takes in a bunch of render config using proper type unions instead of confusing Maybes. This makes the progress bar quite reusable.

type alias RenderConfig msg =
    { state : State
    , maxPosition : Int
    , disabledStyling : Bool
    , onClickMsg : msg
    , allowClick : Bool
    , textFormat : TextFormat
    , shiftLeft : Bool
    }

Snapshots

Create Bigbit Open FS image

Create Bigbit Closed FS image

View Bigbit Open FS image

View Bigbit Closed FS image

amilner42 commented 7 years ago

Don't love the double-scroll bars when < 1024px. May be worth putting the time into a workaround.