search

amimof / huego

An extensive Philips Hue client library for Go with an emphasis on simplicity
MIT License
250 stars 36 forks source link

Proposal: Please start using Semantic Versioning #23

Closed KateGo520 closed 4 years ago

KateGo520 commented 4 years ago

I found that this project already supports Go modules. But sadly, the tags doesn't follow Semantic Versioning, which means that all tags of this project will be ignored by Go modules and replaced by pseudo-versions, go get acts weirdly when tags are not in that form. It would be great to have the tagged release be named in the format vX.X.X format so that go mod can read it. 

    github.com/amimof/huego v0.0.0-20200504200310-b4a8f71aa2e3

Else the mod file shows something like github.com/amimof/huego v0.0.0-20200504200310-b4a8f71aa2e3 which is not very readable and difficult to upgrade. It’s hard to verify which version is in use. This is not conducive to version control

So, I propose this project to follow Semantic Versioning in future versions. For example, v1.0.1, v2.0.0, v3.1.0-alpha, v3.1.0-beta.2etc.

KateGo520 commented 4 years ago

@amimof @smonesi Could you help me review this issue? Thx :p

amimof commented 4 years ago

@KateGo520 Thanks for reporting. I would assume this is because the tags are missing the v prefix. We could simply just add those tags so that the commits have two.

KateGo520 commented 4 years ago

Thank you for your reply! @amimof
That would be great, if the version tag 1.1.0 turns to v1.1.0 .

amimof commented 4 years ago

@KateGo520 See https://github.com/amimof/huego/releases/tag/v1.1.0

KateGo520 commented 4 years ago

@amimof I see the new tag! Thank you for your contribution!

amimof commented 4 years ago

@KateGo520 Thank you! 👏