amimof / huego

An extensive Philips Hue client library for Go with an emphasis on simplicity
MIT License
250 stars 36 forks source link

Remove omitempty from Scene.Recycle #40

Closed ghost closed 3 years ago

ghost commented 3 years ago

Even though the doc states "Set to ‘false’ when omitted.", the bridge actually complains when trying to do just that:

[
    {
        "error": {
            "type": 5,
            "address": "/scenes/recycle",
            "description": "invalid/missing parameters in body"
        }
    }
]
codecov-commenter commented 3 years ago

Codecov Report

Merging #40 (5eeb7cf) into master (e347bf0) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #40   +/-   ##
=======================================
  Coverage   69.71%   69.71%           
=======================================
  Files           5        5           
  Lines        1215     1215           
=======================================
  Hits          847      847           
  Misses        201      201           
  Partials      167      167           
Impacted Files Coverage Δ
scene.go 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e347bf0...5eeb7cf. Read the comment docs.