search

amimof / huego

An extensive Philips Hue client library for Go with an emphasis on simplicity
MIT License
250 stars 36 forks source link

Correct Lights API schema, ProductId to ProductName #44

Closed AliAllomani closed 3 years ago

AliAllomani commented 3 years ago

Lights API doesn't have 'productid' value, instead 'productname' should be there.

Ref. https://developers.meethue.com/develop/hue-api/lights-api/

amimof commented 3 years ago

@AliAllomani Thanks for contributing. Currently the CI-stuff isn't working and I'm working on migrating from Travis CI to GitHub actions. Once that's done I'll be able to merge this.

amimof commented 3 years ago

@AliAllomani New CI-stuff is now in place. Are you able to rebase and push so that a new build is triggered?

AliAllomani commented 3 years ago

@AliAllomani New CI-stuff is now in place. Are you able to rebase and push so that a new build is triggered?

@amimof Done.

codecov-commenter commented 3 years ago

Codecov Report

Merging #44 (8c8f439) into master (5d96804) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #44   +/-   ##
=======================================
  Coverage   73.53%   73.53%           
=======================================
  Files           5        5           
  Lines        1413     1413           
=======================================
  Hits         1039     1039           
  Misses        207      207           
  Partials      167      167
Impacted Files Coverage Δ
light.go 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5d96804...8c8f439. Read the comment docs.