search

amimof / huego

An extensive Philips Hue client library for Go with an emphasis on simplicity
MIT License
250 stars 36 forks source link

Fix: do not shadow stdlib package name with url variable name #58

Closed yunginnanet closed 1 year ago

yunginnanet commented 1 year ago

- What I did do not shadow stdlib package name with url variable

- How I did it refactor variable name

- How to verify it :eyes:

- Description for the CHANGELOG Fix: do not shadow stdlib package name with url variable name

Signed-off-by: kayos@tcp.direct (cherry picked from commit aae82f0355516d3f151d2b3fe586627f5d35c697)

amimof commented 1 year ago

Hi @yunginnanet This make a lot of sense obviously :) I've updated the workflow so the tests should not fail anymore. Go ahead and rebase/force push to trigger the checks off of the change I've done.

codecov-commenter commented 1 year ago

Codecov Report

Merging #58 (7e935b4) into master (5668ae6) will not change coverage. The diff coverage is 96.00%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##           master      #58   +/-   ##
=======================================
  Coverage   73.53%   73.53%           
=======================================
  Files           5        5           
  Lines        1436     1436           
=======================================
  Hits         1056     1056           
  Misses        210      210           
  Partials      170      170
Impacted Files Coverage Δ
bridge.go 63.82% <96.00%> (ø)