amimof / node-cert-exporter

An SSL certificate Prometheus exporter
Apache License 2.0
173 stars 35 forks source link

Add a new label: serial #72

Closed costasd closed 1 year ago

costasd commented 2 years ago

Subject, filename or issuer might remain the same across certificate issuances, say, in renewals.

Serial on the other hand, is an attribute that has quite better chances of changing every time a certificate changes.

So, let's expose it as a label to make in-place renewals a detectable event.

Fixes #71

- What I did

- How I did it

- How to verify it

- Description for the CHANGELOG We now emit each certificate's serial number as a label

amimof commented 1 year ago

@costasd Thanks for contributing. This change looks good to me. Please rebase into master and force push.

costasd commented 1 year ago

Done, thanks!