refactor: Use string.Join to include all header values in curl comman…

amingolmahalle / HttpClientToCurlGenerator

The HttpClientToCurl is a NuGet package for generating curl script of HttpClient in .NET ( C# | CSharp | Dotnet ) supported features: Post, Get, Put, and Delete. content types: application/json, text/xml, application/x-www-form-urlencoded

https://www.nuget.org/packages/HttpClientToCurl

MIT License

51 stars 11 forks source link

refactor: Use string.Join to include all header values in curl comman… #21

Closed Sabermotamedi closed 6 months ago

Sabermotamedi commented 6 months ago

Addresses issue #17. Instead of using header.Value?.FirstOrDefault(), this commit updates the code to use string.Join("; ", header.Value) in order to properly include all values when appending headers in the curl command.

Replaced instances of header.Value?.FirstOrDefault() with string.Join("; ", header.Value).
Ensured that multiple header values are handled correctly.

Closes #17

amingolmahalle commented 6 months ago

@Sabermotamedi we should have a test or tests for this change.

Sabermotamedi commented 6 months ago

I will add it

amingolmahalle commented 6 months ago

Closed: #17