search

amino-os / Amino.Run

Amino Distributed OS - Runtime Manager
Apache License 2.0
29 stars 12 forks source link

[Fixes #516] Go through DM chain for onRPC and UpRPCCall #724

Closed sungwook-moon closed 5 years ago

sungwook-moon commented 5 years ago

Issue summary: Overridden onRPC is not going through the chain. UpRPCCall was added for metric server and this is direct DM call.

Fix: Go through the chain for both cases.

Ignore a few integration tests that fail. This is actually correct since the previous success was due to bypassing the chain and use of a single DM though it defined multiple DMs.

Build

Screen Shot 2019-04-22 at 7 21 45 PM

KVStore & HanksToDO Screen Shot 2019-04-22 at 7 19 29 PM Screen Shot 2019-04-22 at 7 16 56 PM

quinton-hoole commented 5 years ago

Please don't merge this until I've reviewed it.

sungwook-moon commented 5 years ago

Addressed comments and updated PR.

sungwook-moon commented 5 years ago

Replied to the comment and updated to remove upRPCCall from the dmChainMethods.

sungwook-moon commented 5 years ago

It also fixes issue #427