search

amino-os / Amino.Run

Amino Distributed OS - Runtime Manager
Apache License 2.0
29 stars 12 forks source link

Added synchronized access log entries #734

Closed VenuReddy2103 closed 5 years ago

VenuReddy2103 commented 5 years ago

Fixes #717

  1. Concurrent modification exception when log entries are accessed concurrently.
  2. Log consistencies fails and removing conflicting entries in between log replication even when leader is not changed.
  3. Generated toString() methods for amino.run.policy.replication.ConsensusRSMPolicy.RPC and amino.run.policy.util.consensus.raft.LogEntry classes. Might be useful for debugging.
VenuReddy2103 commented 5 years ago

Build log: build.log

quinton-hoole commented 5 years ago

Whooah! This diff is really difficult to read. I tried, but I'm still not quite sure this is right. I think it might be, but I'll have to have another look to confirm. It will require some more time. Sorry.

VenuReddy2103 commented 5 years ago

Code diff report using beyond compare is attached. It is easy to view differences. File is actually html file. But github is not allowing me to attach html here in comment. Remove .txt extension to file and view. Thanks Code Diff Report.html.txt