search

amino-os / Amino.Run

Amino Distributed OS - Runtime Manager
Apache License 2.0
29 stars 12 forks source link

[Examples] Test MinnieTwitter example. #781

Closed sungwook-moon closed 5 years ago

sungwook-moon commented 5 years ago

MinnieTwitter under examples looks to be outdated.

1) The indentation at MinnieTwitterMain is different for example. Confirm the style-format is enforced at build time.

2) There is much unused code such as:

List<User> users = new ArrayList<User>();

3) UserManager is using annotation instead of using a spec to configure which DM to use.

Vishwa4jeet commented 5 years ago
  1. Part 1 of the above issue is already addressed by this PR #786 .
  2. Part 2 has also been addressed by PR #785 .

@sungwook-moon I think this issue can now be closed.

quinton-hoole commented 5 years ago

Thanks @Vishwa4jeet . Agreed. Closing.