search

amino-os / Amino.Run

Amino Distributed OS - Runtime Manager
Apache License 2.0
29 stars 12 forks source link

Avoid swallowing exceptions, to make error reporting and debugging easier #790

Closed quinton-hoole closed 5 years ago

quinton-hoole commented 5 years ago

This PR looks biggish, but all it does is remove try catch blocks that just print out stack traces, and instead lets the exceptions propagate back to callers. Removing the associated indentation makes the PR look bigger than it really is.

quinton-hoole commented 5 years ago

Oh, all checks and examples run correctly:

 ./gradlew examples:run

BUILD SUCCESSFUL in 4m 46s
35 actionable tasks: 35 executed
VenuReddy2103 commented 5 years ago

LGTM

quinton-hoole commented 5 years ago

Still busy wrapping this one up. Will update, rebase and retest this week.

quinton-hoole commented 5 years ago

Addressed comments, rebased, and retested. All tests and examples pass. Merging.