search

amino-os / Amino.Run

Amino Distributed OS - Runtime Manager
Apache License 2.0
29 stars 12 forks source link

Added some missing multi-dm integration tests #802

Closed quinton-hoole closed 5 years ago

quinton-hoole commented 5 years ago

I started adding some missing multidm integration tests to confirm the results in:

https://docs.google.com/spreadsheets/d/1O2flMIe2BWo8x6N87WInqNyvGamk-F4VtV8BngATIRE/edit#gid=0

Before adding more (i.e. all of the rest of the above table), the integration tests need to be rewritten to be automatically generated and table-driven.

I'll do that next, but in the mean time we have a few addional tests.

I also started alphabetising the tests to make it easier to figure out what's there and what's missing.

All tests pass.

See attached test results.

TEST-amino.run.multidm.MultiDMTestCases.xml.zip

AmitRoushan commented 5 years ago

@quinton-hoole Following test cases are removed but not added in alphabetical rearrangement 

testAtLeastOnceRPCConsensusRSMDHT
testAtLeastOnceRPCDHTLoadBalancedMasterSlaveSync
testAtLeastOnceRPCCacheLease
testAtLeastOnceRPCConsensusRSM
testAtLeastOnceRPCConsensusRSMDHT
testAtLeastOnceRPCTwoPCCoordinator
testAtLeastOnceRPCLockingTransaction

Any reason ?

quinton-hoole commented 5 years ago

No, that was not my intention. I'll self-review and correct as necessary tomorrow. Thanks for the prompt review.

On Tue, Jun 25, 2019, 00:07 Amit Roushan notifications@github.com wrote:

@quinton-hoole https://github.com/quinton-hoole Following test cases are removed but not added in alphabetical rearrangement

testAtLeastOnceRPCConsensusRSMDHT testAtLeastOnceRPCDHTLoadBalancedMasterSlaveSync testAtLeastOnceRPCCacheLease testAtLeastOnceRPCConsensusRSM testAtLeastOnceRPCConsensusRSMDHT testAtLeastOnceRPCTwoPCCoordinator testAtLeastOnceRPCLockingTransaction

Any reason ?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/amino-os/Amino.Run/pull/802?email_source=notifications&email_token=AKNAA6HGCERPMLBFYJVHOJLP4G74ZA5CNFSM4H3ELJHKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYPII6I#issuecomment-505316473, or mute the thread https://github.com/notifications/unsubscribe-auth/AKNAA6A3VB4DK2X656MT65LP4G74ZANCNFSM4H3ELJHA .

quinton-hoole commented 5 years ago

Addressed all review comments, and did an additional self-review. All tests pass. Merging.