search

amino-os / Amino.Run

Amino Distributed OS - Runtime Manager
Apache License 2.0
29 stars 12 forks source link

Make MultiDMTestCases be data driven by using JUnit Parameterized Tests. #808

Closed quinton-hoole closed 5 years ago

quinton-hoole commented 5 years ago

Rather than write an explicit test for every possible combination of DM's, here I generate the combinations to programatically create the tests.

Details of Parameterized Tests are here:

https://dzone.com/articles/junit-parameterized-test

140 such autogenerated tests now pass.
An additional 30 are explicitly disabled, mostly due to two broken DMs.

quinton-hoole commented 5 years ago

Made some more progress on this.
Just need to populate the arrays with data now, and do final testing.
20 tests are auto-generated so far, and they all pass.

quinton-hoole commented 5 years ago

Complete. 140 MultiDM tests pass consistently now. The ones that don't are explicitly listed to aid debugging. @VenuReddy2103 or @maheshrajus or @AmitRoushan can I ask you to do one final review please?

PS: Apologies for some of the weird formatting. It's autoformatted by GoogleJavaFormat.

VenuReddy2103 commented 5 years ago

LGTM

AmitRoushan commented 5 years ago

LGTM