search

amino-os / Amino.Run

Amino Distributed OS - Runtime Manager
Apache License 2.0
29 stars 12 forks source link

Upgrade gradle from 4.10 to 5.1.1 #812

Closed quinton-hoole closed 5 years ago

quinton-hoole commented 5 years ago

Replacement for #801 . Complete and ready for review now.

I've broken this up into 5 commits, to make reviewing easier:

  1. initially just let Android Studio do an auto-upgrade, and fix the basic resulting incompatibilities to make build.gradle files compile.
  2. Fix a circular dependency problem in core/build.gradle by removing some incorrect dependencies.
  3. Split microservice directory and file name so that we can declare inputs correctly in gradle 5.1.
  4. Same as above, but for different microservices, and also upgrade GoogleJavaFormat to latest version.
  5. Do some final tidy-up and add some missing dependencies to make sure that everything builds correctly after 'clean' task.

All tests pass, before and after a 'clean':

$ ./gradlew clean check examples:run
BUILD SUCCESSFUL in 6m 3s
115 actionable tasks: 114 executed, 1 up-to-date
quinton-hoole commented 5 years ago

@maheshrajus Could I please ask you to review this?

maheshrajus commented 5 years ago

LGTM

quinton-hoole commented 5 years ago

Thank you @maheshrajus . Merging.