aminography / PrimeDatePicker

PrimeDatePicker is a tool that provides picking a single day, multiple days, and a range of days.
Apache License 2.0
472 stars 52 forks source link

Arabic localized app, shows calender with persian numbers #38

Closed MohamedEmish closed 3 years ago

MohamedEmish commented 4 years ago

set the calendar locale to be "ar", you will see the numbers of days shown are in Persian numbers, we need to show Arabic letters

MohamedEmish commented 4 years ago
private val ARABIC_DIGITS = charArrayOf(
        '0' + 1584,
        '1' + 1584,
        '2' + 1584,
        '3' + 1584,
        '4' + 1584,
        '5' + 1584,
        '6' + 1584,
        '7' + 1584,
        '8' + 1584,
        '9' + 1584
)

You can use these in your languageUtils file and check if the language name is "ar" or else that gonna fix it

aminography commented 3 years ago

Hi @MohamedEmish, Thank you for reporting the issue, I will fix it soon.

MohamedEmish commented 3 years ago

Hi Amin I upgraded the library but the issue still there I tried to contribute to the library but i couldn't push a branch with the fix, so please fix it and keep me updated thanks

On Mon, Nov 30, 2020 at 11:39 AM Amin Hassani notifications@github.com wrote:

Reopened #38 https://github.com/aminography/PrimeDatePicker/issues/38.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/aminography/PrimeDatePicker/issues/38#event-4050979317, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJWPJHYJRU7DQE6FJ4AH2ADSSNR3JANCNFSM4UGWNPOQ .

aminography commented 3 years ago

Sorry for that. Now it is fixed. Update to:

dependencies {
    implementation 'com.aminography:primedatepicker:3.2.2'
    implementation 'com.aminography:primecalendar:1.3.2'
}
MohamedEmish commented 3 years ago

Fixed, Thank you we can close it now